Skip to content

Update NativeBinaries to libgit2 0.27.7 #1639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 28, 2018
Merged

Conversation

ethomson
Copy link
Member

@ethomson ethomson commented Nov 6, 2018

No description provided.

@ethomson
Copy link
Member Author

ethomson commented Nov 6, 2018

sigh

@bording
Copy link
Member

bording commented Nov 6, 2018

Uh oh, any idea what the caused the failures?

@ethomson
Copy link
Member Author

ethomson commented Nov 7, 2018

Uh oh, any idea what the caused the failures?

Not exactly. I encountered this over in #1618, which is that our smart subtransport implementation wasn't quite complete. (In particular, libgit2 can provide a null URL to indicate that you should reconnect.) What's not clear to me is why this suddenly started. I suspect something changed subtly in 0.27.7 - that seems more likely than suddenly a change to GitHub triggering an existing bug in LibGit2Sharp - but I'm not sure what changed yet. In the meantime, I'll cherry-pick the fixes that I made in the other branch.

@ethomson
Copy link
Member Author

ethomson commented Nov 7, 2018

I'm going to hold off on merging this until I do track down the root cause tonight, in case it's a behavior change that we think should be addressed in libgit2.

@ethomson ethomson force-pushed the ethomson/natives_0_27_7 branch from 10aa8c2 to 4271690 Compare November 7, 2018 16:05
@ethomson
Copy link
Member Author

ethomson commented Nov 7, 2018

Yep, was a change in behavior that I accidentally introduced in libgit2 and made it into 0.27.7. Fixing that change over there, then I'll do a proper native binaries build. Oops.

@ethomson ethomson force-pushed the ethomson/natives_0_27_7 branch from 4271690 to e7e41d7 Compare November 28, 2018 22:07
@ethomson ethomson merged commit 426cdbc into master Nov 28, 2018
@ethomson ethomson deleted the ethomson/natives_0_27_7 branch February 15, 2019 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants