Remove obsolete field. #1339
Merged
Remove obsolete field. #1339
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This field was removed from libgit2 a year and a half ago.
|
This was exposed because I was fiddling with the git_fetch_options structure (it is included in the git_clone_options structure), making it bigger before this field. |
|
The calendar time doesn't really say much. Is this removed in the current version of libgit2 we target/bundle? |
|
Yes, it used to be here, but now it is gone. |
|
I linked master, but the commit at which NativeBinaries is targeted is missing the signature field too: https://github.com/libgit2/libgit2/blob/381caf56908ad9cdb5959850a331d7cf2f952e63/include/git2/clone.h#L136-L143 |
|
ping @carlosmn |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This field was removed from libgit2 a year and a half ago.
This is the libgit2 commit: libgit2/libgit2@659cf20#diff-7c9f3aae8ea34d171fe8f44fbedde372L140
This is the libgit2sharp commit: 4c5c088