Skip to content

Conversation

@Atala
Copy link
Contributor

@Atala Atala commented Nov 19, 2014

This settings would enabled easy index overriding when testing.
What do you think about it?

@lauxley
Copy link
Contributor

lauxley commented Nov 20, 2014

It indeed seems like a very good idea, thx.

lauxley added a commit that referenced this pull request Nov 21, 2014
Add a ELASTICSEARCH_DEFAULT_INDEX settings
@lauxley lauxley merged commit 6b20885 into liberation:master Nov 21, 2014
@Atala
Copy link
Contributor Author

Atala commented Nov 23, 2014

Cool! I love the approach you've taken, it's pretty easy to use.

Two things I would like to ask:

  • are you planning to package it properly as a django app?
  • it would be very nice if the class EsIndexable wasn't inheriting from Model, but was a proper mixin (I don't what it would take to do that as it would be harder to plug reindexing signals/manager's logic)

@lauxley
Copy link
Contributor

lauxley commented Nov 24, 2014

Thanks,
I will probably release it on pypy, but it's still pretty early in the dev phase and the code is not very stable yet, so even if the api is probably not going to change a lot, i'd rather wait to have a better test coverage and full docs at least.
Why do you want a mixin rather than a Model subclass ? If it's really a problem can you open an issue and explain why, a closed pr is not the best place to talk about it ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants