Native HCG support implementation #2921
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 4, 2016 19:37
|
It seems you've ignored #2803, did you? So technically it's not that I specifically would argue, but I actually wonder if this is worth being in the core instead of a plugin. |
| @@ -132,6 +132,28 @@ Color.prototype.toHSL = function () { | |||
| } | |||
| return { h: h * 360, s: s, l: l, a: a }; | |||
| }; | |||
| Color.prototype.toHCG = function () { | |||
There was a problem hiding this comment.
This function does not seem to be used anywhere so what is it its purpose?
There was a problem hiding this comment.
For HCG planned modifiers (for example "purity", "absorbtion"). But I thinking about names, that will not conflict with HSL/HSV/HWB. Problem of HCG: they describes material property.
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added support of HCG color model.
Plug-in official for HCG.
https://github.com/acterhd/less-hcg