Skip to content

Conversation

limymy
Copy link

@limymy limymy commented Oct 15, 2025

fix #121

@ClemensSchwarke
Copy link
Collaborator

Hey @limymy, thanks again for the PR :) I don't think we can support recurrent training with symmetry this way, because we would need to be more careful with the hidden states of the network. Simply repeating them should not work because those would not be the hidden states the network produces when encountering the mirrored states "naturally". Does that make sense?

@limymy
Copy link
Author

limymy commented Oct 20, 2025

You're right! In a time series, the movement of different legs will lead to different hidden states, so they cannot be simply copied. Do you have a better idea to solve this problem?

@ClemensSchwarke
Copy link
Collaborator

I think it is not trivial, I will add an error message for now. If you have a good way to implement this let us know! Otherwise, we will adress this later as we currently work on other parts of the library.

@ClemensSchwarke
Copy link
Collaborator

Hey @limymy, I added the error message in #125. I would close this PR for now until we have a proper way of handling the hidden states. Thanks again for bringing this up and creating the PR, it might become useful later :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incorrect batch size calculation for RNN models in symmetric data augmentation

2 participants