Skip to content

fix: skipped deposits of NFT with zero value #399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
troggy merged 5 commits into from
Jan 18, 2020
Merged

fix: skipped deposits of NFT with zero value #399

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0039d66
fix: skipped deposits of NFT with zero value
troggy Jan 18, 2020
b2624ea
6.0.0-preview.0
troggy Jan 18, 2020
2291f2b
add missing logging for NewDeposit event
troggy Jan 18, 2020
e85dad1
6.0.0-preview.1
troggy Jan 18, 2020
ed3086e
reset version back to 5.5.1
troggy Jan 18, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@
"jsbi": "^3.0.0",
"jsbi-utils": "^1.0.0",
"jsondiffpatch": "^0.2.5",
"leap-core": "^0.37.0",
"leap-core": "^1.0.0",
"level": "^6.0.0",
"lodash": "^4.17.13",
"lodash.get": "^4.4.2",
Expand Down
5 changes: 4 additions & 1 deletion src/bridgeState.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,9 @@ module.exports = class BridgeState {

this.handleEvents = handleEvents({
NewDeposit: ({ returnValues: event }) => {
logBridge(
`NewDeposit. id: ${event.depositId} color: ${event.color} amount: ${event.amount} owner: ${event.depositor}`
);
this.deposits[event.depositId] = {
depositor: event.depositor,
color: event.color,
Expand All @@ -95,7 +98,7 @@ module.exports = class BridgeState {
},
NewDepositV2: ({ returnValues: event }) => {
logBridge(
`NewDepositV2. color: ${event.color} amount: ${event.amount} owner: ${event.depositor}`
`NewDepositV2. id: ${event.depositId} color: ${event.color} amount: ${event.amount} owner: ${event.depositor}`
);
this.deposits[event.depositId] = {
depositor: event.depositor,
Expand Down
9 changes: 5 additions & 4 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4306,15 +4306,16 @@ lcid@^2.0.0:
dependencies:
invert-kv "^2.0.0"

leap-core@^0.37.0:
version "0.37.0"
resolved "https://registry.yarnpkg.com/leap-core/-/leap-core-0.37.0.tgz#1f17957d33bccca130c8e167af2c756a8700d0f6"
integrity sha512-9Lj2ibtoDLe9D6++R9CclWMCv/Nf+jiidRRRqgukOOW5b5NdlodSJQMpHa1nw1EL50sl3UImb2GUiYQZJCmFMw==
leap-core@^1.0.0:
version "1.0.0"
resolved "https://registry.yarnpkg.com/leap-core/-/leap-core-1.0.0.tgz#105fe20c3ec2c23c9ba1dbd7c4b0d205a7fc095e"
integrity sha512-edkyGVlBUfpvd3OHLUEGbCJQeWLGR2EAZNsQfXiCzTz2M8wwrk10aqCb3fBNhVTawH3idqlqewJyng5rY1dmYg==
dependencies:
"@types/web3" "^1.0.18"
ethereumjs-util "6.0.0"
jsbi-utils "^1.0.0"
node-fetch "^2.3.0"
web3-core-promievent "^1.2.4"
Copy link
Member

@johba37 johba37 Jan 18, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀


left-pad@^1.3.0:
version "1.3.0"
Expand Down