fix: event subscription code reads the same block twice. #348
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`ContractsEventsSubscription` class reads events in interval `[fromBlock,toBlock]` every root chain block. After each read, it does `fromBlock = toBlock` assignment, to continue reading from `toBlock`. However, both boundaries are included in the iteration. So block at `toBlock` height is already been read within `[fromBlock,toBlock]` iteration. To read the next portion, we have to start from `toBlock + 1`, not from `toBlock`.
Codecov Report
@@ Coverage Diff @@
## master #348 +/- ##
=======================================
Coverage 95.16% 95.16%
=======================================
Files 72 72
Lines 1096 1096
Branches 206 206
=======================================
Hits 1043 1043
Misses 47 47
Partials 6 6
Continue to review full report at Codecov.
|
This was referenced Nov 1, 2019
troggy
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ContractsEventsSubscriptionclass reads events in interval[fromBlock,toBlock]every root chain block. After each read, it doesfromBlock = toBlockassignment, to continue reading fromtoBlock.However, both boundaries are included in the iteration. So block at
toBlockheight is already been read within[fromBlock,toBlock]iteration. To read the next portion, we have to start fromtoBlock + 1, not fromtoBlock.Relates #340