-
Notifications
You must be signed in to change notification settings - Fork 841
feat(AlgebraicGeometry/Morphisms/Flat): add a simple lemma #30237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
feat(AlgebraicGeometry/Morphisms/Flat): add a simple lemma #30237
Conversation
PR summary d9d1cc1012Import changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diff
You can run this locally as follows## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit> The doc-module for No changes to technical debt.You can run this locally as
|
Please avoid pinging people in PR descriptions (this means they get a notification whenever someone does a git rebase involving this commit and pushes it somewhere). If you want to indicate co-authorship, please add a line "Co-authored by: Name " instead. |
My apologies for that. Thank you for letting me know, and I've added |
I'll move base_factorization_type to another file (or try to avoid it) and remove WIP. WIP |
I've decided to exclude everything except -WIP |
Co-authored-by: Christian Merten <[email protected]>
Co-authored-by: Christian Merten <[email protected]>
Thanks! I've committed all the suggestions. -awaiting-author |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but I am a co-author. @erdOne could you please have a look?
This PR introduces the following simple lemma:
AlgebraicGeometry.Flat.flat_and_surjective_iff_faithfullyFlat_of_isAffine
: A morphism between affine schemes is flat and surjective if and only if the corresponding map on global sections is faithfully flat.Co-authored-by: Christian Merten