Inline variable does not overwrite @import variable

[zsinryu]

file "variable.less"
@BODYBG: green;

file "import.less"

@import 'variable.less';

@BODYBG: red;

body {
line-height: 10em;
background: @BODYBG;
}

result:
expected: @BODYBG should be red
actual: @BODYBG is green

Regards

[blakeembrey]

+1

This is a fairly annoying issue when using Bootstrap and overriding with your own variables file to import.

+1

[ldbglobe]

Here a minor change that make the PHP setted variables as !important var (override all same named vars)

https://github.com/ldbglobe/lessphp/compare/patch-1

Not really bugsafe but in my case work perfectly

[tbal]

Figured out, that this false behaviour was introduced with v0.3.7. Bisecting resulted in the following:

ec56e8f0648bd9192c1a361ca0eeb00a02635277 is the first bad commit
commit ec56e8f0648bd9192c1a361ca0eeb00a02635277
Author: leaf corcoran <leafot@gmail.com>
Date:   Tue Aug 7 08:31:29 2012 -0700

    updated PHP api #247 #246

    Added compile, compileFile, checkedCompile, and cachedCompile to
    instance. Deprecating parse and passing a file to constructor.

    Added setVariables to set initial variables from PHP on the instance.

    The static methods ccompile and cexecute now forward to the instance
    methods checkedCompile and cachedCompile.

    The compile functions should have no configuration arguments. They
    should all share the same interface to any compiler settings, which is a
    lessc instance.

    The deprecated code will still be there, and work the same, I'll just
    remove references to it from the documentation.

:100644 100644 7b44ac77f295994c7e13738161ca89a52faeed98 fddf361abdfa7b922f0ce4cb84861954989253b7 M  lessc.inc.php

The patch by ldbglobe also worked for me.

[ds125v]

I'm hitting the same issue I think. My current dodgy workaround is to include a php_variables.less file at the end, which has e.g.

@iconSpritePath: @php_iconSpritePath;

This means I can set php_iconSpritePath via the API and it'll override any other settings of iconSpritePath.

[eminos]

+1
This is a big issue when using it with Bootstrap. It's not parsing as less.js and as expected.
It needs to overwrite imported variables.

[eminos]

@ldbglobe Works for me. I don't know if there are other issues with this patch though. Hope not.

[gavinlove]

I too have ran straight into this problem updated from 0.3.6 and everything was broken as we include bootstrap/variables.less at the top of our variables.less which then overrides the bits we want to change.

[rouffj]

+1. Is there any news for this issue @leafo ?

[Metalchocobo]

+1 Here

[rouffj]

+1

Envoyé de mon iPhone

Le 10 mai 2013 à 01:23, Andrea notifications@github.com a écrit :

+1 Here

—
Reply to this email directly or view it on GitHub.

[aiolos]

@ldbglobe Works for me too, will this patch be applied to master?

[timaschew]

+1
@ldbglobe why you don't make a pull request ?

[eminos]

This is so weird! Seems like the simplest thing, and very very important functionality for LESS.
No comment from @leafo ??
Makes me think we're just doing it wrong? But this is how LESS.js is working!
I will make that fix manually to lessc.php for now, but I'm looking for a better solution, to skip lessphp.

[whiskeysierra]

An effective workaround is to not use inline variables but also import them.