Skip to content

[Draft] Add str to visit_ListItem #800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

AbdelrahmanKhaledd
Copy link
Collaborator

No description provided.

@certik certik requested a review from namannimmo10 July 21, 2022 03:43
@namannimmo10
Copy link
Collaborator

Can you add some tests?

@AbdelrahmanKhaledd
Copy link
Collaborator Author

Can you add some tests?

visit_listItem doesn't work with strings so, i will try to figure out where is the problem and fix it, then i will add some tests.

@czgdp1807
Copy link
Collaborator

czgdp1807 commented Jul 30, 2022

Please merge main into your branch. Lists are now completely implemented in LLVM. See #835

@namannimmo10
Copy link
Collaborator

I think this PR can be closed. Thanks, @Abdelrahman-Kh-Fouad for giving this a try.

@AbdelrahmanKhaledd AbdelrahmanKhaledd deleted the string_item_list branch August 4, 2022 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants