Initial support for structs at ASR, LLVM levels. #611
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
czgdp1807
added
asr
|
@certik This is ready. |
|
@czgdp1807 -- thanks for adding this. 🎉 |
certik
reviewed
Jun 15, 2022
| # TODO: the above constructor does not initialize `A` in LPython yet, so | ||
| # the below does not work: | ||
| #assert x.x == 3 | ||
| #assert x.y == 3.3 |
There was a problem hiding this comment.
You can fix this in a subsequent PR, for now I commented it out.
There was a problem hiding this comment.
I will look into this tomorrow.
certik
approved these changes
Jun 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Side notes
While implementing structs I noticed that
python_ast_to_asr.cppis not well implemented. Instead of using recursion and visiting the child nodes, they are handled manually. We should improve upon this later.