Skip to content

Enabling c backend for test_c_interop_03.py #594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 14, 2022

Conversation

czgdp1807
Copy link
Collaborator

#545 (comment) (2nd point)

@certik
Copy link
Contributor

certik commented Jun 13, 2022

Excellent, thanks for this. After this works for all the other types as well, so we do not need to modify the test, then we can merge it.

@czgdp1807
Copy link
Collaborator Author

Yes. Will continue this tomorrow morning.

@czgdp1807
Copy link
Collaborator Author

Meanwhile feel free to look at the partial C-code generated and let me know if its okay.

@czgdp1807 czgdp1807 marked this pull request as ready for review June 14, 2022 06:05
@czgdp1807 czgdp1807 force-pushed the test_c_interop_03 branch from 7fadeae to a357944 Compare June 14, 2022 06:28
@czgdp1807 czgdp1807 requested a review from certik June 14, 2022 06:28
@czgdp1807
Copy link
Collaborator Author

@certik This is ready.

Copy link
Contributor

@certik certik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Thank you for this. Go ahead and merge this.

@certik certik enabled auto-merge June 14, 2022 06:29
@certik certik merged commit 84bcf1c into lcompilers:main Jun 14, 2022
@czgdp1807 czgdp1807 deleted the test_c_interop_03 branch June 14, 2022 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants