Skip to content

Conversation

@swamishiju
Copy link
Collaborator

Added functionality for set() to accept list argument

@swamishiju swamishiju marked this pull request as draft February 7, 2025 08:17
@swamishiju swamishiju marked this pull request as ready for review February 10, 2025 08:10
@certik
Copy link
Contributor

certik commented Feb 17, 2025

You have to get the CI to pass, currently it is failing at:

{'returncode': 134} != {'returncode': 1}
{'stderr_hash': '32b0a24f111e577fe4fc5b3f4a5994b951e34dde7986b3fb750c5f5e'} != {'stderr_hash': '4811af471c73572b285e9ea01c8689abdd3cb32c717b3cd4876d2669'}
Diff against: tests/reference/run_dbg-test_assert_01-2f34744.stderr
1,7c1,2
<   File "tests/runtime_errors/test_assert_01.py", line 1
<     def test():
<   File "tests/runtime_errors/test_assert_01.py", line 4
<     test()
<   File "tests/runtime_errors/test_assert_01.py", line 2
<     assert False
< AssertionError
---
> *** buffer overflow detected ***: terminated
> Aborted (core dumped)

@swamishiju
Copy link
Collaborator Author

Its weird im on a Mac and python run_tests.py gives all tests passed so im not entirely sure why it isnt working

@ubaidsk
Copy link
Collaborator

ubaidsk commented Feb 17, 2025

I am observing the same issue here. Probably the CI seems to be flaky.

compiler_tester.tester.RunException: Testing with reference output failed.
runtime_errors/test_assert_01.py * run_dbg
The JSON metadata differs against reference results
Reference JSON: tests/reference/run_dbg-test_assert_01-2f34744.json
Output JSON:    tests/output/run_dbg-test_assert_01-2f34744.json
Omitting 9 identical items
Differing items:
{'returncode': 134} != {'returncode': 1}
{'stderr_hash': '32b0a24f111e577fe4fc5b3f4a5994b951e34dde7986b3fb750c5f5e'} != {'stderr_hash': '4811af471c73572b285e9ea01c8689abdd3cb32c717b3cd4876d2669'}
Diff against: tests/reference/run_dbg-test_assert_01-2f34744.stderr
1,7c1,2
<   File "tests/runtime_errors/test_assert_01.py", line 1
<     def test():
<   File "tests/runtime_errors/test_assert_01.py", line 4
<     test()
<   File "tests/runtime_errors/test_assert_01.py", line 2
<     assert False
< AssertionError
---
> *** buffer overflow detected ***: terminated
> Aborted (core dumped)

Copy link
Collaborator

@ubaidsk ubaidsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sgtm

Copy link
Collaborator

@ubaidsk ubaidsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Posted a comment above. Let's fix the message.

Fixed error message

Co-authored-by: Mohammed Ubaid Shaikh <[email protected]>
@swamishiju
Copy link
Collaborator Author

Thank you for pointing it out, I've committed it

@ubaidsk ubaidsk merged commit 22ea159 into lcompilers:main Mar 12, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants