Skip to content

Refactor: Move test_modules folder to integration_tests #2295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

ubaidsk
Copy link
Collaborator

@ubaidsk ubaidsk commented Aug 24, 2023

The test_modules folder is used by integration_tests/test_import_04.py. I think the test_modules folder should not be in the root directory of the project. I think it should ideally reside in integration_tests directory.

@ubaidsk ubaidsk requested a review from certik August 24, 2023 18:23
Copy link
Contributor

@certik certik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I think this is fine.

@certik certik merged commit b33af13 into lcompilers:main Aug 24, 2023
@ubaidsk ubaidsk deleted the move_test_modules_to_integration_tests branch August 25, 2023 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants