Error for incorrect type annotation #1975
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ubaidsk
force-pushed
the
error_for_incorrect_type_ann
branch
from
f60035f to
a6471ba
Compare
Refactor: Assign to type in place of return There is a common return at the end of the function
ubaidsk
force-pushed
the
error_for_incorrect_type_ann
branch
from
a6471ba to
1dded4d
Compare
ubaidsk
commented
Jun 21, 2023
| --> tests/errors/func_08.py:3:17 | ||
| | | ||
| 3 | def main0(x: In[In[i32]]): | ||
| | ^^^^^^^ |
There was a problem hiding this comment.
The error message here is shared with the error message for local variables with annotation In/ InOut / Out. See tests/errors/test_annassign_03.py in this PR. Therefore the error message is kept slightly general to cover both the cases.
|
Ready. |
certik
approved these changes
Jun 21, 2023
|
Beautiful, thank you @Shaikh-Ubaid ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1970