Skip to content

Conversation

czgdp1807
Copy link
Collaborator

Also, all types under Pointer should be of deferred shape. The same rule as Fortran.

@czgdp1807 czgdp1807 marked this pull request as ready for review June 9, 2023 10:14
@certik
Copy link
Contributor

certik commented Jun 9, 2023

I will investigate this later today how Fortran does it. We definitely want this feature, but we might also want to allow setting the size using a function argument (as it was before), so let me investigate first and I'll post here later.

Copy link
Contributor

@certik certik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks great.

I didn't realize before that you just shifted the dimension/shape from the type to an argument, which is better.

Thanks!

@certik certik merged commit 8340b79 into lcompilers:main Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants