Skip to content

Nested Dictionaries Support #1690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Nested Dictionaries Support #1690

wants to merge 1 commit into from

Conversation

harshsingh-24
Copy link
Contributor

@harshsingh-24 harshsingh-24 marked this pull request as draft April 9, 2023 17:57
czgdp1807
czgdp1807 reviewed Apr 10, 2023
View reviewed changes
Copy link
Collaborator

@czgdp1807 czgdp1807 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to complete #1111 for supporting nested dictionaries. The tests you have added are very easy to support. We need to support all the tests in #1111 simultaneously to make sure that the changes aren't fragile.

@harshsingh-24
Copy link
Contributor Author

Yes. You are right @czgdp1807. The changes made here does not run for all possible combinations of string, integers, list in nested dicts. I just opened this PR for further discussions on implementations of it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@czgdp1807 czgdp1807 czgdp1807 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@harshsingh-24 @czgdp1807