Skip to content

Conversation

Smit-create
Copy link
Collaborator

No description provided.

@Smit-create Smit-create marked this pull request as ready for review April 4, 2023 06:32
@Smit-create Smit-create requested review from certik and czgdp1807 April 4, 2023 06:32
_lpython_return_variable = x&y;
return _lpython_return_variable;
}

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not good. Please skip inline function calls pass in C. inline __attribute__((always_inline)) directs the C compiler to do the same and since C language is a high level language so the generated code should be as readable as possible.

@czgdp1807 czgdp1807 marked this pull request as draft April 4, 2023 12:42
@Smit-create Smit-create marked this pull request as ready for review April 4, 2023 13:45
@Smit-create Smit-create added c Label for C language related changes asr_pass ASR pass related changes labels Apr 4, 2023
Copy link
Collaborator

@czgdp1807 czgdp1807 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Smit-create Smit-create merged commit e859831 into lcompilers:main Apr 5, 2023
@Smit-create Smit-create deleted the c_pass branch April 5, 2023 04:51
@certik
Copy link
Contributor

certik commented Apr 5, 2023

Looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

asr_pass ASR pass related changes c Label for C language related changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants