Sync libasr with LFortran
#1535
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
czgdp1807
commented
Feb 20, 2023
| @@ -2529,6 +2559,9 @@ def main(argv): | |||
| subs["MOD"] = "LPython::AST" | |||
| subs["mod"] = "ast" | |||
| subs["lcompiler"] = "lpython" | |||
| elif subs["MOD"] == "AST": | |||
There was a problem hiding this comment.
Shouldn't it be "LFORTRAN" instead of "AST"?
There was a problem hiding this comment.
We haven't been consistent in the asdl if I remember well, so I would not do any big changes in the sync PRs, but we can fix things up later.
certik
reviewed
Feb 20, 2023
|
Otherwise it looks good. |
czgdp1807
force-pushed
the
libasr_sync_2
branch
from
98a2105 to
6f85de9
Compare
czgdp1807
force-pushed
the
libasr_sync_2
branch
2 times, most recently
from
dd6a551 to
60e3bb0
Compare
ubaidsk
reviewed
Feb 20, 2023
|
For the files |
czgdp1807
force-pushed
the
libasr_sync_2
branch
from
60e3bb0 to
132006f
Compare
czgdp1807
force-pushed
the
libasr_sync_2
branch
from
132006f to
51e94cc
Compare
ubaidsk
approved these changes
Feb 20, 2023
czgdp1807
force-pushed
the
libasr_sync_2
branch
from
c2fb2e9 to
9993dcc
Compare
Thirumalai-Shaktivel
approved these changes
Feb 21, 2023
Smit-create
approved these changes
Feb 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corresponding LFortran PR - lfortran/lfortran#1325