C: Codegen to Compare data types #1255
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
czgdp1807
reviewed
Nov 8, 2022
| @@ -78,8 +78,7 @@ class BaseCCPPVisitor : public ASR::BaseVisitor<Struct> | |||
| size_t template_number; | |||
| std::string from_std_vector_helper; | |||
|
|
|||
| std::unique_ptr<CCPPList> list_api; | |||
| std::unique_ptr<CCPPTuple> tuple_api; | |||
| std::unique_ptr<CCPPDSUtils> c_ds_api; | |||
There was a problem hiding this comment.
Is this for wrapping up list_api and tuple_api?
There was a problem hiding this comment.
I removed the individual classes of List/Tuple as there was a lot of repetitive code logic and also it needed frequent interaction of both the classes, I suppose that will be also needed for upcoming data structures like dict, set, etc.
czgdp1807
approved these changes
Nov 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.