Skip to content

Implement arctan, degrees, radians in Numpy. #1062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 2, 2022

Conversation

redbopo
Copy link
Contributor

@redbopo redbopo commented Aug 29, 2022

Seems like degrees, radians not provided in src/libasr/runtime/lfortran_intrinsics.c
I just add each with float and double input type function.

close 960

@redbopo
Copy link
Contributor Author

redbopo commented Aug 30, 2022

Thanks for reviews. @czgdp1807
Now remove the degrees, radians in c runtime.
Instead add pi_32, pi_64 for f32, f64 with them, like cmath.py.

Copy link
Collaborator

@czgdp1807 czgdp1807 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Will clean things up here later this week and merge it. Meanwhile @certik any thoughts from you on this?

@czgdp1807 czgdp1807 enabled auto-merge September 2, 2022 04:37
@czgdp1807 czgdp1807 merged commit de05f9d into lcompilers:main Sep 2, 2022
@redbopo redbopo deleted the issue_960_left branch September 2, 2022 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implementing inverse trigonometric and angle utility functions in NumPy
2 participants