`dict.get()` does not take default argument correctly.

[faze-geek]

def f():
    b:dict[i32,i32] = {1:2}
    print(b.get(3))
    print(b.get(3,100))
f()

(lp) C:\Users\kunni\lpython>python try.py
None                    # When default argument is not given.
100                     # When default argument is given the key 3 is expected to take value 100.

(lp) C:\Users\kunni\lpython>src\bin\lpython try.py
3670136                # Expected since Lpython assigns garbage value for i : i32 declarations. 
3670136                # Unexpected 100 should be assigned.

[faze-geek]

@Smit-create You added these lines in #435. I suspect the error is generated here so could you have a look. Meanwhile I will also investigate this issue.

lpython/src/lpython/semantics/python_attribute_eval.h

Lines 269 to 280 in 2d25371

	static ASR::asr_t* eval_dict_get(ASR::expr_t *s, Allocator &al, const Location &loc,
	Vec<ASR::expr_t*> &args, diag::Diagnostics &diag) {
	ASR::expr_t *def = nullptr;
	if (args.size() > 2 || args.size() < 1) {
	throw SemanticError("'get' takes atleast 1 and atmost 2 arguments",
	loc);
	}
	ASR::ttype_t *type = ASRUtils::expr_type(s);
	ASR::ttype_t *key_type = ASR::down_cast<ASR::Dict_t>(type)->m_key_type;
	ASR::ttype_t *value_type = ASR::down_cast<ASR::Dict_t>(type)->m_value_type;
	if (args.size() == 2) {
	def = args[1];

[Smit-create]

The problem is not with ASR or frontend which I have added in that PR. It's presently not handled in LLVM.

[faze-geek]

The problem is not with ASR or frontend which I have added in that PR. It's presently not handled in LLVM.

Yes I realized that . Could you point out which files have the get method. I'll try to handle this case in LLVM.

[Smit-create]

This is fixed now. The only thing we need to decide is when/how to use None.

[faze-geek]

This is fixed now. The only thing we need to decide is when/how to use None.

Thanks @Smit-create . I will test the pr locally. As far as None is concerned, does it make sense with static typing ? Something like d = {'a':None,'b':1,'c':2} isn't supported as of now.