Skip to content

Add selectable extraColumns to fixTree method #502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: v5
Choose a base branch
from
Open

Add selectable extraColumns to fixTree method #502

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
893bb38
v5 :: Add extra selectableColumns to fixTree method
iforone Mar 22, 2021
1e00334
v5 :: Correctly merge extraColumns in fixTree method
iforone Mar 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/QueryBuilder.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -844,17 +844,17 @@ public function isBroken()
* Nodes with invalid parent are saved as roots.
*
* @param null|NodeTrait|Model $root
*
* @param array $extraColumns
* @return int The number of changed nodes
*/
public function fixTree($root = null)
public function fixTree($root = null, array $extraColumns = [])
{
$columns = [
$columns = array_merge([
$this->model->getKeyName(),
$this->model->getParentIdName(),
$this->model->getLftName(),
$this->model->getRgtName(),
];
], $extraColumns);

$dictionary = $this->model
->newNestedSetQuery()
Expand Down