Skip to content

Conversation

@heoblitz
Copy link
Collaborator

@heoblitz heoblitz commented Jun 19, 2024

What is this PR for?

[13:33:12]: ▸ [FlexLayout] Compiling YGValue.cpp
[13:33:14]: ▸ ::warning file=/Users/runner/work/FlexLayout/FlexLayout/Sources/yoga/include/yoga/YGValue.h,line=12,col=10::double-quoted include "YGEnums.h" in framework header, expected angle-bracketed instead [-Wquoted-include-in-framework-header]
[13:33:14]: ▸ #include "YGEnums.h"
[13:33:14]: ▸          ^~~~~~~~~~~
[13:33:14]: ▸ ::warning file=/Users/runner/work/FlexLayout/FlexLayout/Sources/yoga/include/yoga/YGEnums.h,line=11,col=10::double-quoted include "YGMacros.h" in framework header, expected angle-bracketed instead [-Wquoted-include-in-framework-header]
[13:33:14]: ▸ #include "YGMacros.h"
[13:33:14]: ▸          ^~~~~~~~~~~~

Remove the header compile warnings that occur when building the FlexLayoutInner scheme. Set CLANG_WARN_QUOTED_INCLUDE_IN_FRAMEWORK_HEADER to NO, the same as the Cocoapods target.

@heoblitz heoblitz force-pushed the remove_ci_compile_warning branch from 8b06a5d to faf9fc1 Compare June 19, 2024 11:39
Copy link
Member

@lucdion lucdion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@lucdion lucdion merged commit e533519 into layoutBox:master Jun 20, 2024
@heoblitz heoblitz deleted the remove_ci_compile_warning branch June 23, 2024 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants