-
Notifications
You must be signed in to change notification settings - Fork 28
feat: [MTRX-1308] Add archived field to launchdarkly_metrics resources #348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
sasthana-ld
wants to merge
6
commits into
main
Choose a base branch
from
MTRX-1308-add-archived-field-support-to-launchdarkly-metric-terraform-resource
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
feat: [MTRX-1308] Add archived field to launchdarkly_metrics resources #348
sasthana-ld
wants to merge
6
commits into
main
from
MTRX-1308-add-archived-field-support-to-launchdarkly-metric-terraform-resource
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Siddharth Asthana <[email protected]>
df4ce49 to
165ed1f
Compare
165ed1f to
5ced881
Compare
echatman
reviewed
Sep 10, 2025
echatman
reviewed
Sep 10, 2025
ldhenry
reviewed
Sep 19, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good so far. Feel free to request a review of myself or @sloloris when you are ready.
ember-stevens
approved these changes
Oct 16, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ for the docs updates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds archived boolean field to launchdarkly_metric resource to allow users to mark metrics as archived through Terraform.
added TO-DO comments for api client since ldapi.MetricPost does not support Archived field yet so when LD api client is merged I will uncomment the archived field code in create/update operations
made changes as we have discussed in Tech spec: https://docs.google.com/document/d/1HKRRgdSnHoXjrLnzRY9_7hQw4Q5pW9Q_AQdpO0wTm9w/edit?tab=t.0#heading=h.lcgpt7k0oisq
Jira Ticket: https://launchdarkly.atlassian.net/browse/MTRX-1308
DB PR: https://github.com/launchdarkly/gonfalon/pull/51985
Backend PR: https://github.com/launchdarkly/gonfalon/pull/51995
Wait!
Testing
For any changes you make, please ensure your acceptance test conform to the following:
ImportStateandImportStateVerifyare set to true.ImportStateVerifyIgnorecan be used if we explicitly expect a value to be different when imported, such as in the case of obfuscated values like API keysLaunchDarkly Employees
For more information on how to build, test, and release, see the internal provider runbook.
Related Jira issue: MTRX-1308: Add archived field support to launchdarkly_metric Terraform resource