feat: plugin implementation #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mario-launchdarkly
force-pushed
the
feature/plugins
branch
2 times, most recently
from
471eb18 to
45b618d
Compare
Vadman97
approved these changes
Aug 15, 2025
There was a problem hiding this comment.
nice! makes sense to me pending my comments. would get @tanderson-ld 's thoughts as well
tanderson-ld
requested changes
Aug 15, 2025
Sources/ObserveAPI/Metric.swift
Outdated
| public let name: String | ||
| public let value: Double | ||
| public let attributes: [String: AttributeValue] | ||
| public let timestamp: TimeInterval? |
There was a problem hiding this comment.
Add comment that this time interval is from unix epoch.
There was a problem hiding this comment.
it is epoch only if you get the TimeInterval from Date().timeIntervalSince1970 method otherwise it is representing seconds, https://developer.apple.com/documentation/foundation/nsdate/timeintervalsince1970, so we are ok
There was a problem hiding this comment.
How will someone know what value to provide here? They need to know which epoch the time interval is referenced from. Usually it is assumed to be the 1970 epoch, but a comment helps positively define that.
mario-launchdarkly
force-pushed
the
feature/plugins
branch
2 times, most recently
from
80fdff2 to
08a9eba
Compare
tanderson-ld
approved these changes
Aug 18, 2025
|
I assume we have not added bugbot to this repo? I think we should. |
kinyoklion
reviewed
Aug 18, 2025
kinyoklion
reviewed
Aug 18, 2025
mario-launchdarkly
force-pushed
the
feature/plugins
branch
from
08a9eba to
d4b6820
Compare
yeah good idea, that's one of the reasons we're bringing this back to the monorepo |
mario-launchdarkly
force-pushed
the
feature/plugins
branch
from
d4b6820 to
c38588c
Compare
|
@mario-launchdarkly addressed outstanding feedback |
Vadman97
pushed a commit
that referenced
this pull request
Oct 23, 2025
🤖 I have created a release *beep* *boop* --- ## [0.4.0](swift-launchdarkly-observability-v0.3.0...swift-launchdarkly-observability-v0.4.0) (2025-10-23) ### Features * Add GraphQL Client ([5e52365](5e52365)) * add gzip compression ([d2133a7](d2133a7)) * Add LightWeight GraphQL Client ([ed9f6b5](ed9f6b5)) * Add LightWeight GraphQL Client ([#12](#12)) ([ed9f6b5](ed9f6b5)) * add standard output logger for debug ([#16](#16)) ([435f4cb](435f4cb)) * add tap handler, send span ([#7](#7)) ([96cf5ef](96cf5ef)) * add timeout for custom crash filter as param (10s default) ([daaa111](daaa111)) * instrumentation and session managers ([b6f1c05](b6f1c05)) * instrumentation and session managers ([#1](#1)) ([a072154](a072154)) * instrumentation, client, sdk, crash report, network ([2255e48](2255e48)) * instrumentation, client, sdk, crash report, network ([#5](#5)) ([df712ab](df712ab)) * ios26 transition ([0853a19](0853a19)) * plugin implementation ([c38588c](c38588c)) * plugin implementation ([#4](#4)) ([1849209](1849209)) * sampling api ([#10](#10)) ([242149f](242149f)) * set sampling config via graphql client ([#19](#19)) ([500f550](500f550)) * swipe tracker ([4fca19d](4fca19d)) * swipe tracker ([#13](#13)) ([0a302d7](0a302d7)) * **system-metrics:** add auto instrumentation for cpu and memory ([#36](#36)) ([95ca6fc](95ca6fc)) * use apple format for crash report ([1390973](1390973)) ### Bug Fixes * compilation ([bdd3e22](bdd3e22)) * eval hook ([2749468](2749468)) * eval hook ([#8](#8)) ([4b60b80](4b60b80)) * get sampling config ([#21](#21)) ([12e35c7](12e35c7)) * guard inconsistent [weak self] ([59dce74](59dce74)) * Limit Package.swift to iOS and TV ([#34](#34)) ([7d76b65](7d76b65)) * requirement 1.2.3.6 span name in eval hook ([#14](#14)) ([ad15ef9](ad15ef9)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). <!-- CURSOR_SUMMARY --> --- > [!NOTE] > Prepare 0.4.0 release: add changelog and bump manifest version. > > - **Docs**: > - Add `CHANGELOG.md` for `0.4.0`, outlining new features and bug fixes. > - **Release**: > - Bump version in `.release-please-manifest.json` from `0.3.0` to `0.4.0`. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 4381ca4. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.