Skip to content

Fix incorrect endpoint in update_user_flag_settings #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
slumos wants to merge 1 commit into from
Closed

Fix incorrect endpoint in update_user_flag_settings #58

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions lib/ldclient-rb/settings.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,11 @@ def update_user_flag_setting(user_key, flag_key, setting=nil)
@config.logger.error("[LDClient] Must specify user")
return
end


user_setting_endpoint = "#{@config.base_uri}/api/users/#{user_key}/features/#{flag_key}"
@config.logger.debug "[LDClient] Setting: #{user_setting_endpoint}"
res = log_timings('update_user_flag_setting') do
@client.put("#{@config.base_uri}/api/users/#{user_key}/features/#{flag_key}") do |req|
@client.put(user_setting_endpoint) do |req|
req.headers['Authorization'] = "api_key #{@api_key}"
req.headers['User-Agent'] = "RubyClient/#{LaunchDarkly::VERSION}"
req.headers['Content-Type'] = 'application/json'
Expand All @@ -34,6 +36,7 @@ def update_user_flag_setting(user_key, flag_key, setting=nil)

unless res.success?
@config.logger.error("[LDClient] Failed to change setting, status: #{res.status}")
return nil
end
end
end
Expand Down
8 changes: 6 additions & 2 deletions spec/ldclient_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,15 +16,19 @@
end

context 'user flag settings' do
let(:config) { client.instance_variable_get :@config }
let(:http_client) { client.instance_variable_get :@client }
let(:setting_endpoint) { "#{config.base_uri}/api/users/#{user[:key]}/features/#{feature[:key]}" }

describe '#update_user_flag_setting' do
it 'requires user' do
expect(client.instance_variable_get(:@config).logger).to receive(:error)
expect(config.logger).to receive(:error)
client.update_user_flag_setting(nil, feature[:key], true)
end

it 'puts the new setting' do
result = double('result', success?: true, status: 204)
expect(client.instance_variable_get(:@client)).to receive(:put).and_return(result)
expect(http_client).to receive(:put).with(setting_endpoint).and_return(result)
client.update_user_flag_setting(user[:key], feature[:key], true)
end
end
Expand Down