Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/ldclient-rb/requestor.rb
Original file line number Diff line number Diff line change
Expand Up @@ -60,9 +60,9 @@ def make_request(path)
headers: headers
})
status = response.status.code
@config.logger.debug { "[LDClient] Got response from uri: #{uri}\n\tstatus code: #{status}\n\theaders: #{response.headers}\n\tbody: #{res.to_s}" }
# must fully read body for persistent connections
body = response.to_s
@config.logger.debug { "[LDClient] Got response from uri: #{uri}\n\tstatus code: #{status}\n\theaders: #{response.headers.to_h}\n\tbody: #{body}" }
if status == 304 && !cached.nil?
body = cached.body
else
Expand Down
13 changes: 13 additions & 0 deletions spec/requestor_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,19 @@ def with_requestor(base_uri, opts = {})
end
end

it "logs debug output" do
logger = ::Logger.new($stdout)
logger.level = ::Logger::DEBUG
with_server do |server|
with_requestor(server.base_uri.to_s, { logger: logger }) do |requestor|
server.setup_ok_response("/", { flags: { x: { key: "y" } } }.to_json)
expect do
requestor.request_all_data()
end.to output(/\[LDClient\] Got response from uri\:/).to_stdout_from_any_process
end
end
end

it "sends etag from previous response" do
etag = "xyz"
with_server do |server|
Expand Down