Skip to content

fix: Update force_encoding to operate on unfrozen string #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
keelerm84 merged 1 commit into from
Jul 15, 2025
Merged

fix: Update force_encoding to operate on unfrozen string #60

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/ld-eventsource/impl/buffered_line_reader.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,8 @@ def self.lines_from(chunks)

Enumerator.new do |gen|
chunks.each do |chunk|
chunk.force_encoding("ASCII-8BIT")
buffer << chunk
chunk = chunk.dup.force_encoding("ASCII-8BIT")
buffer += chunk

loop do
# Search for a line break in any part of the buffer that we haven't yet seen.
Expand Down