Skip to content

Use less memory while parsing initial large payloads #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eli-darkly merged 1 commit into from
Jun 15, 2022
Merged

Use less memory while parsing initial large payloads #32

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 13 additions & 8 deletions lib/ld-eventsource/impl/event_parser.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,12 +37,14 @@ def items
event = maybe_create_event
reset_buffers
gen.yield event if !event.nil?
else
case line
when /^(\w+): ?(.*)$/
item = process_field($1, $2)
gen.yield item if !item.nil?
end
elsif (colon = line.index(':'))
name = line.slice(0...colon)

# delete the colon followed by an optional space
line = line.slice(colon...).delete_prefix(':').delete_prefix(" ")

item = process_field(name, line)
gen.yield item if !item.nil?
end
end
end
Expand All @@ -62,8 +64,11 @@ def process_field(name, value)
when "event"
@type = value.to_sym
when "data"
@data << "\n" if @have_data
@data << value
if @have_data
@data << "\n" << value
else
@data = value
end
@have_data = true
when "id"
if !value.include?("\x00")
Expand Down