Skip to content

add doc comment + test for new method #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eli-darkly merged 1 commit into from
Aug 11, 2021
Merged

add doc comment + test for new method #16

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions lib/ld-eventsource/client.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,6 +190,11 @@ def close
end
end

#
# Tests whether the client has been shut down by a call to {Client#close}.
#
# @return [Boolean] true if the client has been shut down
#
def closed?
@stopped.value
end
Expand Down
15 changes: 15 additions & 0 deletions spec/client_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -426,4 +426,19 @@ def send_stream_content(res, content, keep_open:)
end
end
end

it "returns true from closed? when closed" do
with_server do |server|
server.setup_response("/") do |req,res|
send_stream_content(res, "", keep_open: true)
end

with_client(subject.new(server.base_uri)) do |client|
expect(client.closed?).to be(false)

client.close
expect(client.closed?).to be(true)
end
end
end
end