Skip to content

Conversation

@Vadman97
Copy link
Contributor

@Vadman97 Vadman97 commented Sep 25, 2025

Summary

Update SDK go version to 1.25

How did you test this change?

CI

Are there any deployment considerations?

no


Note

Adds a new Go OpenTelemetry e2e example with collector config, upgrades Go and OTel dependencies across modules, and changes log/error spans to use Producer kind.

  • E2E OpenTelemetry (Go):
    • Add e2e/opentelemetry/go module with example server (main.go, rolldice.go), OTel setup (otel.go), and collector config (collector.yml, compose.yml).
  • Build/Tooling:
    • Bump Go versions in modules to go 1.23.8; Dockerfile runs go mod tidy.
  • Dependencies:
    • Upgrade OpenTelemetry to v1.38.0 (and related exporters/metric/log packages), otelhttp v0.63.0, gqlgen v0.17.71, gqlparser v2.5.25, testify v1.11.1, fiber v2.52.9, and various transitive deps across e2e/* and sdk/highlight-go.
  • SDK Behavior:
    • Use trace.SpanKindProducer for log/logrus/Vercel/HTTP log spans and RecordError (was Client).
  • Misc:
    • Minor import alias cleanups; update GraphQL tracer test to use concrete Tracer type.

Written by Cursor Bugbot for commit 57be778. This will update automatically on new commits. Configure here.

@Vadman97 Vadman97 changed the title update to go 1.25 chore: update to go 1.25 Oct 2, 2025
@Vadman97 Vadman97 marked this pull request as ready for review October 4, 2025 00:12
@Vadman97 Vadman97 requested a review from a team as a code owner October 4, 2025 00:12
cursor[bot]

This comment was marked as outdated.

Copy link
Member

@kinyoklion kinyoklion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't lint the launchdarkly_flutter_observability folder. I believe I already removed it from the linting rules, so maybe old base?

Actually there is a few crazy lint things going on? Maybe linting the repo above?

@Vadman97
Copy link
Contributor Author

Vadman97 commented Oct 6, 2025

Please don't lint the launchdarkly_flutter_observability folder. I believe I already removed it from the linting rules, so maybe old base?

Actually there is a few crazy lint things going on? Maybe linting the repo above?

hmmm, so I was trying to update the observability repo to update the git submodule, and the observability repo has it's own lint that applies to the submodule which caused all of this. not sure if the ignores were added there - will figure out how to turn it off

@Vadman97 Vadman97 merged commit de306bd into main Oct 10, 2025
26 checks passed
@Vadman97 Vadman97 deleted the vadim/go-1-25 branch October 10, 2025 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants