Skip to content

fix: remove useless defaults #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 24, 2023
Merged

fix: remove useless defaults #94

merged 1 commit into from
Apr 24, 2023

Conversation

@yusinto
Copy link
Contributor

@yusinto yusinto commented Apr 23, 2023 •
edited
Loading

The options below are already defined with the same defaults in the common sdk-server Configuration class so we can safely remove them for the edge sdk to avoid repetition:

  stream: false,
  sendEvents: false,
  // offline: false,
  useLdd: true,
  // allAttributesPrivate: false,
  // privateAttributes: [],
  // contextKeysCapacity: 1000,
  // contextKeysFlushInterval: 300,
  diagnosticOptOut: true,
  // diagnosticRecordingInterval: 900,
  logger: BasicLogger.get(),

@shortcut-integration
Copy link

shortcut-integration bot commented Apr 23, 2023

This pull request has been linked to Shortcut Story #198557: Remove redundant defaults.

@yusinto yusinto merged commit a9f533a into main Apr 24, 2023
@yusinto yusinto deleted the yus/sc-198557/remove-redundant-defaults branch April 24, 2023 17:30
@github-actions github-actions bot mentioned this pull request Apr 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kinyoklion kinyoklion kinyoklion approved these changes

@louis-launchdarkly louis-launchdarkly Awaiting requested review from louis-launchdarkly

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@yusinto @kinyoklion