feat: support cjs and esm for cloudflare and edge common #87
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…udfare packageInfo.
…Cleaned up description and removed esbuild config.
|
This pull request has been linked to Shortcut Story #196410: Bundle cloudflare output. |
Merged
kinyoklion
reviewed
Apr 19, 2023
kinyoklion
reviewed
Apr 19, 2023
| "lib": [ | ||
| "es2021" | ||
| ] /* Specify a set of bundled library declaration files that describe the target runtime environment. */, | ||
| "jsx": "react" /* Specify what JSX code is generated. */, |
Member
There was a problem hiding this comment.
Do we need jsx for some reason?
Contributor
Author
There was a problem hiding this comment.
This comes default from wrangler init. We don't need jsx in our example app, but maybe others may in their apps.
kinyoklion
reviewed
Apr 19, 2023
…dme. removed unused app.js file.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.