fix: Requestor initialized with wrong withReasons and useReport config #869
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@artyorsh Thank you for finding this! I will do some validation and then get it released. |
Contributor
Author
|
Ouch :) Why it fails? I unfortunately don't have more time for the issue, hope it is incorrectly implemented test and there is enough context already. |
Member
Some of the builds require permissions that are not compatible with forks. We probably should disable those steps, but I will check the builds to make sure everything is fine. |
kinyoklion
approved these changes
May 22, 2025
Merged
kinyoklion
pushed a commit
that referenced
this pull request
May 22, 2025
🤖 I have created a release *beep* *boop* --- <details><summary>jest: 0.1.7</summary> ## [0.1.7](jest-v0.1.6...jest-v0.1.7) (2025-05-22) ### Dependencies * The following workspace dependencies were updated * dependencies * @launchdarkly/react-native-client-sdk bumped from ~10.10.1 to ~10.10.2 </details> <details><summary>react-native-client-sdk: 10.10.2</summary> ## [10.10.2](react-native-client-sdk-v10.10.1...react-native-client-sdk-v10.10.2) (2025-05-22) ### Bug Fixes * Requestor initialized with wrong withReasons and useReport config ([#869](#869)) ([2e095c5](2e095c5)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Related issues
#868
Describe the solution you've provided
Provides Requestor configuration in correct order.
Describe alternatives you've considered
None.
Additional context
Fixes #868
Edit: in functions with many arguments, consider arguments with an object, so that it's more clear what values are assigned to which keys.