Skip to content

feat: lazy load jsonParser and yamlParser FlagFileParser #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tanderson-ld merged 3 commits into from
Jan 22, 2025
Merged

feat: lazy load jsonParser and yamlParser FlagFileParser #35

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fa4a12b
lazy load jsonParser and yamlParser FlagFileParser
jtjeferreira May 29, 2024
69535ec
Merge remote-tracking branch 'upstream/main' into lazy-load-FlagFileP…
jtjeferreira Dec 20, 2024
8b1ca2a
use getter
jtjeferreira Dec 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions .../server/src/main/java/com/launchdarkly/sdk/server/integrations/FileDataSourceParsing.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,14 +72,24 @@ static final class FlagFileRep {
}

static abstract class FlagFileParser {
private static final FlagFileParser jsonParser = new JsonFlagFileParser();
private static final FlagFileParser yamlParser = new YamlFlagFileParser();
static class JsonParserHolder {
private static final JsonFlagFileParser INSTANCE = new JsonFlagFileParser();
static JsonFlagFileParser getInstance() {
return INSTANCE;
}
}
static class YamlParserHolder {
private static final YamlFlagFileParser INSTANCE = new YamlFlagFileParser();
static YamlFlagFileParser getInstance() {
return INSTANCE;
}
}

public abstract FlagFileRep parse(InputStream input) throws FileDataException, IOException;

public static FlagFileParser selectForContent(byte[] data) {
Reader r = new InputStreamReader(new ByteArrayInputStream(data));
return detectJson(r) ? jsonParser : yamlParser;
return detectJson(r) ? JsonParserHolder.getInstance() : YamlParserHolder.getInstance();
}

private static boolean detectJson(Reader r) {
Expand Down
Loading