feat: Add plugins registration result handling #318
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Plugins now receive registration results via onPluginsReady, and PluginMetadata requires a version. Creates RegistrationCompleteResult to track plugin registration success or failure. Updates tests and interfaces to support these changes.
agrognetti
changed the title
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
launchdarkly-android-client-sdk/src/main/java/com/launchdarkly/sdk/android/LDClient.java
Show resolved
Hide resolved
Updated the error log message in LDClient to clarify that the exception occurred during execution of onPluginsReady for a plugin, rather than during registration.
tanderson-ld
approved these changes
Dec 9, 2025
Adds a new `getId()` and `getVersion` methods to the `PluginMetadata` abstract class, returning empty strings by default.
agrognetti
deleted the
agrognetti/add-plugins-registration-result-callback
branch
agrognetti
added a commit
that referenced
this pull request
Dec 11, 2025
🤖 I have created a release *beep* *boop* --- ## [5.10.0](5.9.2...5.10.0) (2025-12-11) ### Features * Add plugins registration result handling ([#318](#318)) ([ea4a41c](ea4a41c)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). <!-- CURSOR_SUMMARY --> --- > [!NOTE] > Release 5.10.0 adding plugins registration result handling. > > - **Feature**: > - Add plugins registration result handling (documented in `CHANGELOG.md`). > - **Versioning**: > - Bump SDK version to `5.10.0` in `gradle.properties` and `.release-please-manifest.json`. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit a3a15aa. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Note
Tracks plugin registration success/failures and invokes onPluginsReady with results; extends PluginMetadata with id/version.
LDClient):RegistrationCompleteResult.plugin.onPluginsReady(result, metadata)after registration for each environment.Plugin: addsonPluginsReady(RegistrationCompleteResult, EnvironmentMetadata)default no-op.PluginMetadata: addsgetId()andgetVersion()accessors (default empty), keepsgetName()abstract.RegistrationCompleteResultsealed class withSuccessandFailure(List<PluginFailure>).name,version, andid.Written by Cursor Bugbot for commit a14d9c3. This will update automatically on new commits. Configure here.