cargo fix cannot be used with sqlx offline mode

[ihor-rud]

Hi,
Running cargo fix on a project that uses sqlx::query! in offline mode panics while compilation.

error: proc macro panicked
...
= help: message: Invalid `cargo metadata` output: Error("EOF while parsing a value", line: 1, column: 0)
= note: this error originates in the macro `sqlx::query` (in Nightly builds, run with -Z macro-backtrace for more info)

It look like calling cargo metadata under cargo fix has different behavior. It expects to receive additional argument if __CARGO_FIX_PLZ is set.

I'd be happy to submit a PR but I dont know what would be the best fix to that.

[Palmik]

I am having the same issue, but only when building within Docker. Did you find a workaround?

[frxstrem]

I don't know if it's the best way to solve this, but it seems like the following patch is sufficient to get cargo fix to work with offline mode:

diff --git a/sqlx-macros/src/query/mod.rs b/sqlx-macros/src/query/mod.rs
index a2f17874..4e2ba900 100644
--- a/sqlx-macros/src/query/mod.rs
+++ b/sqlx-macros/src/query/mod.rs
@@ -81,6 +81,7 @@ static METADATA: Lazy<Metadata> = Lazy::new(|| {
         let output = Command::new(&cargo)
             .args(&["metadata", "--format-version=1"])
             .current_dir(&manifest_dir)
+            .env_remove("__CARGO_FIX_PLZ")
             .output()
             .expect("Could not fetch metadata");

[jplatte]

You should probably just create a PR for that :)

Sounds like a fine workaround to me until this is (hopefully) fixed in cargo.

[abonander]

Closed by #1352