(issue 165) remember size of main window and internal components #191
Conversation
alixdamman
changed the title
larray_editor/comparator.py
Outdated
| @@ -263,13 +263,20 @@ def _setup_and_check(self, widget, data, title, readonly, **kwargs): | |||
| main_splitter.addWidget(comparatorwidget) | |||
| main_splitter.setSizes([5, 95]) | |||
| main_splitter.setCollapsible(1, False) | |||
| self.widget_state_settings['{}_main_splitter'.format(self.name)] = main_splitter | |||
There was a problem hiding this comment.
wouldn't it be cleaner if you didn't use self.name in the dict keys (but added it in save_widgets_state_and_geometry and restore_widgets_state_and_geometry)?
|
One more thing: remember most of (all in this case) my review comments are suggestions of how I think we could do better. You are free to disagree that it is actually better (and don't need to explain why). |
|
In one of your previous comment:
I am not sure of how to implement the "get_widgets_with_state_to_restore()" method? |
As I said above, forget about it. I meant the manual subclass override but what you have now is simpler anyway. |
|
OK to merge? |
larray_editor/editor.py
Outdated
| def save_widgets_state_and_geometry(self): | ||
| settings = QSettings() | ||
| settings.beginGroup(self.settings_group_name) | ||
| settings.setValue('geometry/{}'.format(self.name), self.saveGeometry()) |
There was a problem hiding this comment.
isn't using self.name redundant now that you are using beginGroup(self.settings_group_name)? (and it causes the resulting string to mix technical/lowercase strings with "user friendly" strings).
|
LGTM (modulo history cleanup of course), nice work! |
…ompare() function as in the edit() function
alixdamman
force-pushed
the
165_remember_size
branch
from
05c5fbf to
c8e2330
Compare
No description provided.