Skip to content

refactor: simplify prop usage in Vue components #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 24, 2025
Merged

refactor: simplify prop usage in Vue components #15

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion resources/js/components/AppHeader.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,7 @@ const rightNavItems: NavItem[] = [

<div v-if="props.breadcrumbs.length > 1" class="flex w-full border-b border-sidebar-border/70">
<div class="mx-auto flex h-12 w-full items-center justify-start px-4 text-neutral-500 md:max-w-7xl">
<Breadcrumbs :breadcrumbs="props.breadcrumbs" />
<Breadcrumbs :breadcrumbs="breadcrumbs" />
</div>
</div>
</div>
Expand Down
4 changes: 2 additions & 2 deletions resources/js/components/AppearanceTabs.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ interface Props {
class?: string;
}

const props = withDefaults(defineProps<Props>(), {
const { class: containerClass } = withDefaults(defineProps<Props>(), {
class: '',
});

Expand All @@ -20,7 +20,7 @@ const tabs = [
</script>

<template>
<div :class="['inline-flex gap-1 rounded-lg bg-neutral-100 p-1 dark:bg-neutral-800', props.class]">
<div :class="['inline-flex gap-1 rounded-lg bg-neutral-100 p-1 dark:bg-neutral-800', containerClass]">
<button
v-for="{ value, Icon, label } in tabs"
:key="value"
Expand Down
2 changes: 1 addition & 1 deletion resources/js/components/Icon.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,5 +26,5 @@ const icon = computed(() => {
</script>

<template>
<component :is="icon" :class="className" :size="props.size" :stroke-width="props.strokeWidth" :color="props.color" />
<component :is="icon" :class="className" :size="size" :stroke-width="strokeWidth" :color="color" />
</template>
4 changes: 2 additions & 2 deletions resources/js/layouts/AppLayout.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,13 +6,13 @@ interface Props {
breadcrumbs?: BreadcrumbItemType[];
}

const props = withDefaults(defineProps<Props>(), {
withDefaults(defineProps<Props>(), {
breadcrumbs: () => [],
});
</script>

<template>
<AppLayout :breadcrumbs="props.breadcrumbs">
<AppLayout :breadcrumbs="breadcrumbs">
<slot />
</AppLayout>
</template>
4 changes: 2 additions & 2 deletions resources/js/layouts/app/AppHeaderLayout.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,14 +8,14 @@ interface Props {
breadcrumbs?: BreadcrumbItemType[];
}

const props = withDefaults(defineProps<Props>(), {
withDefaults(defineProps<Props>(), {
breadcrumbs: () => [],
});
</script>

<template>
<AppShell class="flex-col">
<AppHeader :breadcrumbs="props.breadcrumbs" />
<AppHeader :breadcrumbs="breadcrumbs" />
<AppContent>
<slot />
</AppContent>
Expand Down
4 changes: 2 additions & 2 deletions resources/js/layouts/app/AppSidebarLayout.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ interface Props {
breadcrumbs?: BreadcrumbItemType[];
}

const props = withDefaults(defineProps<Props>(), {
withDefaults(defineProps<Props>(), {
breadcrumbs: () => [],
});
</script>
Expand All @@ -18,7 +18,7 @@ const props = withDefaults(defineProps<Props>(), {
<AppShell variant="sidebar">
<AppSidebar />
<AppContent variant="sidebar">
<AppSidebarHeader :breadcrumbs="props.breadcrumbs" />
<AppSidebarHeader :breadcrumbs="breadcrumbs" />
<slot />
</AppContent>
</AppShell>
Expand Down