Integrate nova-js into core

[alexbowers]

Made a comment on nova-js, but will post here too for visibility.

Currently, it's really difficult to get nova-js setup for being able to change any of its code. Moving the nova-js into core will make it much easier.

I have done the work required to do this, and from my testing there is no side effects regarding compilation times, size of output, but it does make it drastically easier to work with and contribute towards.

0001-Import-nova-js-into-nova-core.txt

[alexbowers]

https://github.com/laravel/nova-js/issues/2 reference

[davidhemphill]

Like I mentioned in our chat, relative module references when combined with symlinks on windows can have issues with path repositories. We have to be able to make sure this kind of thing isn't a problem before doing so: https://mobile.twitter.com/taylorotwell/status/999690442273800198

[alexbowers]

@davidhemphill I am using the same relative module references that are being used inside of the Nova core already, for example in components.js it is used heavily to refer to components:

...
import DeleteResourceModal from '@/components/Modals/DeleteResourceModal'
import Dropdown from '@/components/Dropdown'
import DropdownMenu from '@/components/DropdownMenu'
import DropdownTrigger from '@/components/DropdownTrigger'
...

I don't see how these would be treated any differently than the ones that already exist in the project.

[davidhemphill]

Have you tested this on Windows to confirm the symlinking issue is not a problem?

[alexbowers]

I have not, I do not have a windows machine to test on

[alexbowers]

However, I don't see how I would have created any additional issues that Nova does not already have if that is the case, since I am copying the same technique being used by other parts of Nova, namely all of the components

[cretueusebiu]

@davidhemphill You don't have to import the real module, just make nova-js available globally in the Nova build and when a package needs it, you can simply specify it via the externals option for webpack.

See #388

[taylorotwell]

This repository is for tracking bugs. Feature requests may be emailed to Nova customer support.