[12.x] Make Blueprint Resolver Statically

[finagin]

Bug

The facade \Illuminate\Support\Facades\Schema calls db.schema, which is not a singleton. As a result, calling Schema::blueprintResolver has no effect.

Solution

Adding the static modifier will make the property accessible across all instances. Furthermore, allowing blueprintResolver to accept null values will provide the ability to revert to the default builder if the custom builder was intended for single-use only.

Compatibility

Since this functionality is currently not fully operational, fixing this bug does not pose any compatibility issues.

[taylorotwell]

But facades cache their own copy of the resolved instance, regardless of binding type?

[finagin]

Hi @taylorotwell
The Schema facade uses cache property with a value of false, which prevents it from being cached, in the code below the one you showed in the screenshot.

framework/src/Illuminate/Support/Facades/Schema.php

Lines 55 to 62 in f9a96f7

	class Schema extends Facade
	{
	/**
	* Indicates if the resolved facade should be cached.
	*
	* @var bool
	*/
	protected static $cached = false;

framework/src/Illuminate/Support/Facades/Facade.php

Lines 231 to 244 in f9a96f7

	protected static function resolveFacadeInstance($name)
	{
	if (isset(static::$resolvedInstance[$name])) {
	return static::$resolvedInstance[$name];
	}
	if (static::$app) {
	if (static::$cached) {
	return static::$resolvedInstance[$name] = static::$app[$name];
	}
	return static::$app[$name];
	}
	}

[finagin]

I don't see the reason for prohibiting caching for this facade. However, considering that this feature first appeared for this facade, there is probably a valid reason for it. Perhaps the author of this feature can help us, @driesvints.

[rodrigopedra]

As a workaround, until this is published, you can call this from a Service Provider's register() method:

$this->callAfterResolving('db.schema', function ($schemaBuilder) {
    $schemaBuilder->blueprintResolver(function ($connection, $table, $callback) {
        // ...
    });
});