Skip to content

[12.x] Fix collection value() method to properly handle falsy values (issue #54910) #54960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

[12.x] Fix collection value() method to properly handle falsy values (issue #54910) #54960

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5b8f79e
Fix collection value() method to properly handle falsy values
phadaphunk Mar 10, 2025
c8fcbae
Update src/Illuminate/Collections/Traits/EnumeratesValues.php
phadaphunk Mar 10, 2025
ee6ff83
Add test to make sure items without the key are not returned by the v…
phadaphunk Mar 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Illuminate/Collections/Traits/EnumeratesValues.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -330,7 +330,7 @@ public function firstWhere($key, $operator = null, $value = null)
*/
public function value($key, $default = null)
{
if ($value = $this->firstWhere($key)) {
if ($value = $this->first()) {
return data_get($value, $key, $default);
}

Expand Down
29 changes: 29 additions & 0 deletions tests/Support/SupportCollectionTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1144,6 +1144,35 @@ public function testValue($collection)
$this->assertEquals(['value' => 'foo'], $c->value('pivot'));
$this->assertEquals('foo', $c->value('pivot.value'));
$this->assertEquals('bar', $c->where('id', 2)->value('pivot.value'));

// Test falsy values
$c = new $collection([
['id' => 1, 'score' => 0],
['id' => 2, 'score' => 100],
]);

$this->assertSame(0, $c->value('score'));

$c = new $collection([
['id' => 1, 'active' => false],
['id' => 2, 'active' => true],
]);

$this->assertSame(false, $c->value('active'));

$c = new $collection([
['id' => 1, 'code' => '0'],
['id' => 2, 'code' => '123'],
]);

$this->assertSame('0', $c->value('code'));

$c = new $collection([
['id' => 1, 'description' => ''],
['id' => 2, 'description' => 'Some description'],
]);

$this->assertSame('', $c->value('description'));
}

#[DataProvider('collectionClassProvider')]
Expand Down
Loading