[6.x] Backport for fix issue with polymorphic morphMaps with literal 0 (#35364) #35487
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix: use strict null check on morphTo type * test: assert 0 relation_type is handled correctly
GrahamCampbell
approved these changes
Dec 4, 2020
dmytro-laba
suggested changes
Dec 4, 2020
There was a problem hiding this comment.
IMO, this will break the backwards compatibility for cases where $this->{$type} is empty string. At least in my project it throws an exception.
I'd suggest adding an explicit check for zero there (in addition to empty) or checking the length of $this->{$type}.
This was referenced Mar 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of #35364 to Laravel 6 LTS.