Bug fix: Updated tests/Cookie/CookieTest.php #242
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed the second portion of testCookiesAreCreatedWithProperOptions() so that it uses the $c2 variable all the way through, as I believe was intended.
taylorotwell
added a commit
that referenced
this pull request
Feb 5, 2013
Bug fix: Updated tests/Cookie/CookieTest.php
|
Thanks |
dbpolito
pushed a commit
to dbpolito/framework
that referenced
this pull request
Oct 1, 2019
Force overriding `handle` by throwing an exception
gonzalom
pushed a commit
to Hydrane/tmp-laravel-framework
that referenced
this pull request
Oct 12, 2023
[5.1] Append middleware of action to group middleware
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the second portion of testCookiesAreCreatedWithProperOptions() so that it uses the $c2 variable all the way through, as I believe was intended. Currently it's testing $c twice ($cookie->make()), and not testing $c2 ($cookie->forever()).