Adding connectTimeout() and timeout() options #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonmccreary
requested changes
Sep 2, 2022
Collaborator
jasonmccreary
left a comment
jasonmccreary
left a comment
There was a problem hiding this comment.
Thanks. But I'm not sure why the .gitignore file was changed.
Contributor
Author
|
All done. Ready for review. |
jasonmccreary
approved these changes
Sep 2, 2022
Collaborator
|
Okay. I'm not sure why the build isn't running. But I'll go ahead and merge this as it should trigger on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the
connectTimeout()(setting up the initial HTTP connection) andtimeout()(the entire transaction) options.