Skip to content

fix: update notice for users for clear-orphaned-file-records and remove-orphaned-files-on-storage commands #18864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 27, 2025

Conversation

kurokobo
Copy link
Contributor

Summary

This is follow-up for #18835 to improve notice for users.

  • The backup to be obtained before proceeding remove-orphaned-files-on-storage command should be from storage, not the database. I have corrected the wording.
  • Since it may cause high load, I have made it display that running within the maintenance window is recommended.

Screenshots

Before After
image image
Before After
image image

Checklist

Important

Please review the checklist below before submitting your pull request.

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. 📚 documentation Improvements or additions to documentation labels Apr 27, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Apr 27, 2025
@crazywoola crazywoola merged commit bed47df into langgenius:main Apr 27, 2025
6 checks passed
@kurokobo kurokobo deleted the free-up-storage branch April 27, 2025 05:04
jsincorporated pushed a commit to jsincorporated/asaAi that referenced this pull request Jul 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📚 documentation Improvements or additions to documentation lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants