Skip to content

fix(promptMessage): correct field_serializer implementation for content serialization #18458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 21, 2025

Conversation

Nov1c444
Copy link
Contributor

Summary

Added a field_serializer for the "content" attribute in UserPromptMessage to properly handle different content types:

  • Return content as-is for None or string values
  • Process list-type content by converting model objects to dictionaries
  • Return other content types unchanged

This fixes serialization issues when UserPromptMessage contains complex content structures, especially when lists include model objects that need to be properly serialized for JSON conversion.

Fixes #18355

Screenshots

Before After
... ...

Checklist

Important

Please review the checklist below before submitting your pull request.

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. 🐞 bug Something isn't working labels Apr 21, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Apr 21, 2025
@crazywoola crazywoola merged commit f191d37 into main Apr 21, 2025
9 checks passed
@crazywoola crazywoola deleted the fix/message-pydantic-warning branch April 21, 2025 07:09
jsincorporated pushed a commit to jsincorporated/asaAi that referenced this pull request Jul 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pydantic parsing warnings when handling multimodal prompt_messages
2 participants