Skip to content

Metadata variable value fix #16665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 25, 2025
Merged

Conversation

JohnJyong
Copy link
Contributor

@JohnJyong JohnJyong commented Mar 24, 2025

  1. fix get wrong format number variable value
  2. fix string variable contains /n /r

Summary

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

fix #16649
close #16651

Tip

Close issue syntax: Fixes #<issue number> or Resolves #<issue number>, see documentation for more details.

Screenshots

Before After
... ...

Checklist

Important

Please review the checklist below before submitting your pull request.

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

2. fix string variable contains /n /r
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. 🐞 bug Something isn't working labels Mar 24, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Mar 25, 2025
@crazywoola crazywoola merged commit 86a1859 into main Mar 25, 2025
9 checks passed
@crazywoola crazywoola deleted the fix/number-variable-metadata-value branch March 25, 2025 01:07
parambharat pushed a commit to parambharat/dify that referenced this pull request Mar 31, 2025
jsincorporated pushed a commit to jsincorporated/asaAi that referenced this pull request Jul 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When using variable number type metadata in the Knowledge Retrieval node, filtering didn't work as expected.
2 participants