fix(langgraph): handle toSerialized() if present to handle V1 changes
#1659
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hntrl
reviewed
Sep 12, 2025
Comment on lines
+126
to
+143
| function _defaultReplacer(this: any, key: string, value: any) { | ||
| const original = this[key] as unknown; | ||
| if ( | ||
| typeof original === "object" && | ||
| original != null && | ||
| "toSerialized" in original && | ||
| typeof original.toSerialized === "function" | ||
| ) { | ||
| return original.toSerialized(); | ||
| } | ||
|
|
||
| return _default(value); | ||
| } | ||
|
|
||
| export class JsonPlusSerializer implements SerializerProtocol { | ||
| protected _dumps(obj: any): Uint8Array { | ||
| const encoder = new TextEncoder(); | ||
| return encoder.encode( | ||
| stringify(obj, (_: string, value: any) => { | ||
| return _default(value); | ||
| }) | ||
| ); | ||
| return encoder.encode(stringify(obj, _defaultReplacer)); |
There was a problem hiding this comment.
nit: can we just make this a condition inside of _default?
There was a problem hiding this comment.
No, since we need the pre-serialized object
Comment on lines
+128
to
+133
| if ( | ||
| typeof original === "object" && | ||
| original != null && | ||
| "toSerialized" in original && | ||
| typeof original.toSerialized === "function" | ||
| ) { |
There was a problem hiding this comment.
would it be helpful to export a a isSerializable fn from core?
There was a problem hiding this comment.
Maybe after we release @langchain/core
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.